Skip to content

Fix RPIT in default async trait method #108304

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Swatinem opened this issue Feb 21, 2023 · 0 comments · Fixed by #114267
Closed

Fix RPIT in default async trait method #108304

Swatinem opened this issue Feb 21, 2023 · 0 comments · Fixed by #114267
Assignees
@compiler-errors
Labels
A-async-await Area: Async & Await AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. C-bug Category: This is a bug. F-async_fn_in_trait Static async fn in traits F-return_position_impl_trait_in_trait `#![feature(return_position_impl_trait_in_trait)]` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Swatinem
Copy link
Contributor

Removing the identity_future from the async lowering in #104833 will regress the tests/ui/impl-trait/in-trait/default-body-with-rpit.rs test.

This is deemed acceptable for now as that feature is still unstable, as long as we track progress to fix it, hence this issue.

See also #104833 (comment), CC @compiler-errors
@Swatinem Swatinem mentioned this issue Feb 21, 2023
Merged
@compiler-errors compiler-errors self-assigned this Feb 21, 2023
@Noratrieb Noratrieb added C-bug Category: This is a bug. F-return_position_impl_trait_in_trait `#![feature(return_position_impl_trait_in_trait)]` A-async-await Area: Async & Await F-async_fn_in_trait Static async fn in traits T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 23, 2023
@eholk eholk added the AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. label Feb 27, 2023
@compiler-errors compiler-errors mentioned this issue Jul 30, 2023
Merged
@bors bors closed this as completed in 692d764 Jul 31, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@compiler-errors compiler-errors

Labels
A-async-await Area: Async & Await AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. C-bug Category: This is a bug. F-async_fn_in_trait Static async fn in traits F-return_position_impl_trait_in_trait `#![feature(return_position_impl_trait_in_trait)]` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
return position impl trait in traits
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Map RPITIT's opaque type bounds back from projections to opaques compiler-errors/rust
4 participants
@eholk @Swatinem @compiler-errors @Noratrieb