Skip to content

The constant core::num::ASCII_CASE_MASK is wrongly described in the doc comment. #109508

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
papok opened this issue Mar 23, 2023 · 2 comments · Fixed by #109666
Closed

The constant core::num::ASCII_CASE_MASK is wrongly described in the doc comment. #109508

papok opened this issue Mar 23, 2023 · 2 comments · Fixed by #109666

Comments

@papok
Copy link

papok commented Mar 23, 2023

/// If 6th bit set ascii is upper case.
const ASCII_CASE_MASK: u8 = 0b0010_0000;

Shouldn't the comment line read : /// If 6th bit set ascii is lower case. ?

@papok papok changed the title The constant core::num::ASCII_CASE_MASK is wronlgly described in the doc comment. The constant core::num::ASCII_CASE_MASK is wrongly described in the doc comment. Mar 23, 2023
@jyn514
Copy link
Member

jyn514 commented Mar 25, 2023

Why?

@papok
Copy link
Author

papok commented Mar 27, 2023

Without further explanation I understand "set" for a bit to be set to 1. In ASCII, if the 6th bit is set to 1 then the letter coded (if the character coded is a letter) is lowercase.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants