Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove rustdoc intra-doc-link macro resolution fallback #110879

Closed
jyn514 opened this issue Apr 27, 2023 · 0 comments · Fixed by #110881
Closed

Remove rustdoc intra-doc-link macro resolution fallback #110879

jyn514 opened this issue Apr 27, 2023 · 0 comments · Fixed by #110881
Labels
A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Apr 27, 2023

In #96676, @petrochenkov added a compatibility hack (#96676 (comment)) to rustdoc so that macros that failed to resolve would still generate a link even though they weren't in scope, to prevent unnecessarily breaking docs. It's been nearly a year since then; I think we can remove the hack now.
@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name labels Apr 27, 2023
@jyn514 jyn514 mentioned this issue Apr 27, 2023
Closed
@bvanjoi bvanjoi mentioned this issue Apr 27, 2023
Merged
@ojeda ojeda mentioned this issue Apr 27, 2023
Open
17 tasks
@bors bors closed this as completed in 0246af8 Apr 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(docs): remove macro resolution fallback bvanjoi/rust
1 participant
@jyn514