Install bootstrap fails to use configured prefix due to Tarball add_renamed_file

[okeuday]

I tried this code, due to installing from source:

rust/src/bootstrap/dist.rs

Line 1074 in b652d9a

tarball.add_renamed_file(etc.join("cargo.bashcomp.sh"), "etc/bash_completion.d", "cargo");

with the installation commands:

./configure --prefix=/path/to/installation/using/a/non/root/user/rust-1.69.0 --enable-extended
python3 ./x.py build
python3 ./x.py install

I expected to see the installation succeed.

Instead, the installation failed when processing the cargo installation. Only the cargo installation uses the Tarball add_renamed_file function, so the problem appears isolated to that single function call, due to the implementation of add_renamed_file.

Meta

rustc --version --verbose:

rustc 1.69.0-dev (84c898d65 2023-04-16) (built from a source tarball)
binary: rustc
commit-hash: 84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc
commit-date: 2023-04-16
host: x86_64-unknown-linux-gnu
release: 1.69.0-dev
LLVM version: 15.0.7

Backtrace

The output only describes the installation failing with only cargo installed.  I didn't save the output.

[albertlarsan68]

Seems related to #110906

[okeuday]

@albertlarsan68 Thank you for pointing-out #110906 ! It is the same problem. Closing this as a duplicate.

[albertlarsan68]

It is not an issue, but this PR will fix this issue. Reopening to keep track of progress.

[albertlarsan68]

@okeuday Does the PR fix the issue?

[okeuday]

@albertlarsan68 When #110906 is combined with #109256 , the 1.69.0 rustc release is able to compile and install successfully (from https://static.rust-lang.org/dist/rustc-1.69.0-src.tar.gz linked at https://forge.rust-lang.org/infra/other-installation-methods.html#source-code) as shown below:

wget https://static.rust-lang.org/dist/rustc-1.69.0-src.tar.gz
tar zxvf rustc-1.69.0-src.tar.gz
cd rustc-1.69.0-src
wget https://github.com/rust-lang/rust/pull/109256.patch
wget https://github.com/rust-lang/rust/pull/110906.patch
patch -p1 < 109256.patch
patch -p1 < 110906.patch
./configure --prefix=/path/to/installation/using/a/non/root/user/rust-1.69.0 --enable-extended
python3 ./x.py build
python3 ./x.py install