Skip to content

tests: double check if tests contain incorrect follow-up error annotation syntax //| instead of //~| #127155

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
jieyouxu opened this issue Jun 30, 2024 · 1 comment
Closed

tests: double check if tests contain incorrect follow-up error annotation syntax //| instead of //~| #127155

jieyouxu opened this issue Jun 30, 2024 · 1 comment
Assignees
@jieyouxu
Labels
A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

If e.g. //| HELP is used, I believe it is just disregarded by compiletest and no help message is actually checked.
@jieyouxu jieyouxu added A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. A-compiletest Area: The compiletest test runner labels Jun 30, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 30, 2024
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 30, 2024
@jieyouxu jieyouxu mentioned this issue Jun 30, 2024
Merged
@jieyouxu jieyouxu self-assigned this Jun 30, 2024
@jieyouxu
Copy link
Member Author

Actually a cursory search shows just tests/ui/return/tail-expr-as-potential-return.rs being the one test that seems to have this problem.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@jieyouxu jieyouxu

Labels
A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
compiletest maintenance and improvements
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jieyouxu @rustbot