Skip to content

regression: mismatched types #128891

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
BoxyUwU opened this issue Aug 9, 2024 · 4 comments
Closed

regression: mismatched types #128891

BoxyUwU opened this issue Aug 9, 2024 · 4 comments
Labels
regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone

Comments

@BoxyUwU
Copy link
Member

BoxyUwU commented Aug 9, 2024

[INFO] [stdout] error[E0308]: mismatched types
[INFO] [stdout]    --> /opt/rustwide/cargo-home/git/checkouts/kobold-39364116f2711f0d/53eacf6/crates/kobold/src/stateful/hook.rs:167:13
[INFO] [stdout]     |
[INFO] [stdout] 167 |             cb as UnsafeCallback<S>
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^ expected `event::Event<T, E>`, found `web_sys::Event`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `web_sys::Event` and `event::Event<T, E>` have similar names, but are actually distinct types
[INFO] [stdout] note: `web_sys::Event` is defined in crate `web_sys`
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/web-sys-0.3.61/src/features/gen_Event.rs:4:1
[INFO] [stdout]     |
[INFO] [stdout] 4   | #[wasm_bindgen]
[INFO] [stdout]     | ^^^^^^^^^^^^^^^
[INFO] [stdout] note: `event::Event<T, E>` is defined in the current crate
[INFO] [stdout]    --> /opt/rustwide/cargo-home/git/checkouts/kobold-39364116f2711f0d/53eacf6/crates/kobold/src/event.rs:12:1
[INFO] [stdout]     |
[INFO] [stdout] 12  | pub struct Event<T = HtmlElement, E = web_sys::Event> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: `dyn CallbackFn<S, web_sys::Event>` implements `CallbackFn` so you could box the found value and coerce it to the trait object `Box<dyn CallbackFn>`, you will have to change the expected type as well
[INFO] [stdout]     = note: this error originates in the attribute macro `wasm_bindgen` (in Nightly builds, run with -Z macro-backtrace for more info)
@BoxyUwU BoxyUwU added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Aug 9, 2024
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Aug 9, 2024
@BoxyUwU BoxyUwU removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 9, 2024
@compiler-errors
Copy link
Member

Apparently this regressed in #127486, but I'm not totally certain which one would've caused this.

@compiler-errors
Copy link
Member

Oh, definitely due to the dyn pointer casting #120248: https://github.com/maciejhirsz/kobold/blob/53eacf69d2ea3f25a47e58a3ccd11dcaf73d48bf/crates/kobold/src/stateful/hook.rs#L193-L198

Anyways, this is a very old version of kobold, and it seems like the downstream crate is specifically using a version before this cast is removed.

@apiraino
Copy link
Contributor

Downstream project (kobold-test) doesn't seem super active. Do we want to keep it in our crater run?

@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Aug 12, 2024
@Mark-Simulacrum Mark-Simulacrum added this to the 1.82.0 milestone Oct 11, 2024
@apiraino
Copy link
Contributor

I'm going to close this as not an actionable for us

@apiraino apiraino closed this as not planned Won't fix, can't repro, duplicate, stale Oct 15, 2024
@apiraino apiraino added regression-from-stable-to-stable Performance or correctness regression from one stable version to another. and removed regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Oct 15, 2024
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Oct 15, 2024
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Oct 15, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants