Skip to content

[rustdoc search] kind filters should not be allowed in type-based search #129909

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
lolbinarycat opened this issue Sep 2, 2024 · 2 comments
Open

[rustdoc search] kind filters should not be allowed in type-based search #129909

lolbinarycat opened this issue Sep 2, 2024 · 2 comments
Labels
A-rustdoc-search Area: Rustdoc's search feature A-type-based-search Area: Searching rustdoc pages using type signatures C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@lolbinarycat
Copy link
Contributor

queries like bool -> fn:new are nonsense and should not be accepted.
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 2, 2024
@lolbinarycat lolbinarycat added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-type-based-search Area: Searching rustdoc pages using type signatures A-rustdoc-search Area: Rustdoc's search feature labels Sep 2, 2024
@fmease fmease added C-bug Category: This is a bug. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Sep 4, 2024
@notriddle
Copy link
Contributor

It doesn't make sense with fn:, but it makes perfect sense with primitive:bool -> struct:new.

@lolbinarycat
Copy link
Contributor Author

addressed by #131852

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-rustdoc-search Area: Rustdoc's search feature A-type-based-search Area: Searching rustdoc pages using type signatures C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@notriddle @fmease @lolbinarycat @rustbot