Skip to content

allow_internal_unstable valid on non proc-macros #133791

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
jdonszelmann opened this issue Dec 3, 2024 · 1 comment
Open

allow_internal_unstable valid on non proc-macros #133791

jdonszelmann opened this issue Dec 3, 2024 · 1 comment
Assignees
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jdonszelmann
Copy link
Contributor

jdonszelmann commented Dec 3, 2024

This bug was technically noticed before, in #69399. That issue was closed without fixing the issue (instead fixing another issue).

Found the bug looking at this gem of a function:

Image

if it's a function;
look if it's a proc macro and return
if it's not a proc macro, also return.....

Anyway, I'll fix this with the attribute handling rework (#131229), I'm just opening the issue to track the fact that this is now a known bug.

@rustbot claim
@rustbot label +A-Attributes

@jdonszelmann jdonszelmann added the C-bug Category: This is a bug. label Dec 3, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 3, 2024
@rustbot rustbot added the A-attributes Area: Attributes (`#[…]`, `#![…]`) label Dec 3, 2024
@jdonszelmann
Copy link
Contributor Author

@rustbot label -needs-triage

@rustbot rustbot removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 3, 2024
@fmease fmease added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 3, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants