-
Notifications
You must be signed in to change notification settings - Fork 13.4k
minicore
: use the host's core
when available
#134652
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
This comment has been minimized.
This comment has been minimized.
I feel like this would introduce a larger danger of writing a test that uses something that's not part of minicore (but is part of core). We'd still catch it eventually in a full bors run on a different arch, but this seems like an unnecessary footgun for the otherwise very reliable no_core tests. |
Something else loosely discussed on Zulip is that maybe |
I'm going to unassign myself for the time being because I don't know how to best approach this, since if a test is |
Also opened #137531 to track how to check deviations between |
I think I agree with nikic that using two different configurations seems more error-prone than just one. |
I agree as well, we shouldn't use two different versions of this for two different configurations. So let's close this in favor of #137531. |
From discussion at https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Using.20.60minicore.60.20for.20more.20compiletests, it would be ideal to replace
minicore
with the host'score
if that is built. @jieyouxu pointed out that this did exist for the ABI compatibility test at some point adb6d47#diff-55f122dec36f78625c830ef254174f8ac89b16959557e11dff4d33ef9fd12438L70.The main advantage here is it gives us a better chance of catching (unlikely) deviations between
core
andminicore
, as opposed to always usingminicore
.The text was updated successfully, but these errors were encountered: