Skip to content

Find root cause why inlining GlobalCtxt::enter causes a crash in the deadlock handler #136499

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
bjorn3 opened this issue Feb 3, 2025 · 2 comments
Open

Find root cause why inlining GlobalCtxt::enter causes a crash in the deadlock handler #136499

bjorn3 opened this issue Feb 3, 2025 · 2 comments
Labels
A-parallel-compiler Area: parallel compiler C-bug Category: This is a bug. E-help-wanted Call for participation: Help is requested to fix this issue. E-needs-investigation Call for partcipation: This issues needs some investigation to determine current status I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics.

Comments

@bjorn3
Copy link
Member

bjorn3 commented Feb 3, 2025

cc #135870 (comment)

This could be a miscompilation or UB somewhere in rustc.
@bjorn3 bjorn3 added C-bug Category: This is a bug. I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics. A-parallel-compiler Area: parallel compiler labels Feb 3, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 3, 2025
@bjorn3 bjorn3 mentioned this issue Feb 3, 2025
Closed
@lqd lqd added A-parallel-queries E-needs-investigation Call for partcipation: This issues needs some investigation to determine current status labels Feb 3, 2025
@jieyouxu jieyouxu added E-help-wanted Call for participation: Help is requested to fix this issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Feb 3, 2025
@Zoxc
Copy link
Contributor

Zoxc commented Mar 23, 2025

You were storing &&GlobalCtxt instead of &GlobalCtxt in CurrentGcx in #134302. I would prefer the enter method to be separate, maybe move it to CurrentGcx?

@bjorn3
Copy link
Member Author

bjorn3 commented Mar 23, 2025

🤦

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-parallel-compiler Area: parallel compiler C-bug Category: This is a bug. E-help-wanted Call for participation: Help is requested to fix this issue. E-needs-investigation Call for partcipation: This issues needs some investigation to determine current status I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Zoxc @lqd @bjorn3 @jieyouxu @rustbot