Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add a tidy check to enforce that all compiler/*/Cargo.tomlcontains lints.workspace = true #138195

Open
jieyouxu opened this issue Mar 8, 2025 · 0 comments
Open

Add a tidy check to enforce that all compiler/*/Cargo.tomlcontains lints.workspace = true #138195

jieyouxu opened this issue Mar 8, 2025 · 0 comments
Assignees
@nnethercote
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. A-tidy Area: The tidy tool C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Mar 8, 2025

To consistently enforce lints across all compiler/ crates after #138084.

I.e. check that all compiler crates have

[lints]
workspace = true

see #138084 (comment) #138084 (comment).

See also #138106; note that this is only applicable for non-tool lints (i.e. not for rustc::xxx internal tool lints).
@jieyouxu jieyouxu added A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. A-tidy Area: The tidy tool C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 8, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 8, 2025
@jieyouxu jieyouxu mentioned this issue Mar 8, 2025
Merged
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 8, 2025
@nnethercote nnethercote self-assigned this Mar 8, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@nnethercote nnethercote

Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. A-tidy Area: The tidy tool C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nnethercote @jieyouxu @rustbot