Skip to content

Automatically run grammar tests (grammar bot) #28592

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
edunham opened this issue Sep 22, 2015 · 7 comments
Closed

Automatically run grammar tests (grammar bot) #28592

edunham opened this issue Sep 22, 2015 · 7 comments
Labels
A-grammar Area: The grammar of Rust C-feature-request Category: A feature request, i.e: not implemented / a PR. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@edunham
Copy link
Member

edunham commented Sep 22, 2015

How to grammar tests: make check-grammar #2234
How to add bot to Travis build matrix: #28500

@edunham edunham changed the title Automatically run grammar tests Automatically run grammar tests (grammar bot) Sep 22, 2015
@alexcrichton
Copy link
Member

cc #15880, I think maybe the original issue? not sure... Has some dependency information though!

@dns2utf8
Copy link
Contributor

I would like to take this on.

@edunham
Copy link
Member Author

edunham commented Aug 22, 2016

@dns2utf8, thanks for volunteering! Is there anything we can do to help you out here?

@fhahn
Copy link
Contributor

fhahn commented Sep 1, 2016

@dns2utf8 are you still working on it? If not, I could have a look this weekend.

@dns2utf8
Copy link
Contributor

dns2utf8 commented Nov 16, 2016

Sorry it took so long. To answer the questions: The bot needs antlr4, bison, flex and all the build tools required for rustc.

As soon as #37607 is merged, a simple make check-grammar check-lexer will run all current test.

If I did it myself I would probably use a docker container with Arch inside.

@dns2utf8
Copy link
Contributor

I created the PR #37825 but my local dry-runs failed to compile llvm inside any docker container.

@Mark-Simulacrum Mark-Simulacrum added the A-grammar Area: The grammar of Rust label May 16, 2017
@Mark-Simulacrum Mark-Simulacrum added T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. and removed A-infrastructure labels Jun 25, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-feature-request Category: A feature request, i.e: not implemented / a PR. label Jul 24, 2017
@steveklabnik
Copy link
Member

Triage: there's the new grammar WG, and they're tracking this themselves, I'm going to close in favor of rust-lang/wg-grammar#5

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-grammar Area: The grammar of Rust C-feature-request Category: A feature request, i.e: not implemented / a PR. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants