-
Notifications
You must be signed in to change notification settings - Fork 13.3k
-C soft-float
silently ignored on x86
#31798
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
I think it might be a good idea to prevent users in case this option cannot be run. Want to do it @petevine? |
Provided it's not too difficult I probably wouldn't want to tread on your patch anyway ;) |
I didn't start, that's why I asked you before doing anything. |
I know, it was a pun. Are we talking about a warning or an error? |
My bad! :p Since it's unavoidable, displaying an error which says something like "this option is not available on this computer" just before leaving seems fine to me. Do you confirm @Manishearth? |
I suggest we add a warning, not error. Often such flags are passed down by the build system with a "make it work if possible" intention, so we shouldn't crash. |
It is a bug we ignore the option and we should fix that instead. Software float emulation is possible regardless of target, but might need some extra libraries (e.g. |
On 32-bit
x86
compiling with-C soft-float
produces a binary but judging from the generated assembly this option is silently ignored.Even if it's silly to expect this to work in absence of library support, shouldn't a warning be printed at least?
The text was updated successfully, but these errors were encountered: