-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update Readme Instructions for 32-bit MinGW Builds #38743
Comments
Thanks for the report @camlorn! To clarify, what's happening here is:
Overall I think we should recommend MSVC first, then 64-bit GNU, then 32-bit GNU if we really need to, but ideally we could relegate this information to outside the readme as it's "weird to follow" |
As I read the readme, it is currently implying that you need MinGW to perform a MSVC build, as the first paragraph mentions other dependencies that are perhaps not needed. Given that Windows is my primary platform, it is ironic that I have not yet built Rustc under MSVC. As a concrete solution, perhaps:
|
Triage: the README still says:
|
AFAIK 32 bit MinGW builds are fine nowadays. |
I've build Rust with 32-bit MinGW like dozen times now and there are no issues with the README steps. We can close this I think. |
I found out this was incorrect when I had to build Rust on 32-bit Windows for a failing test to do with #37429. I want to say it was @alexcrichton who gave me the workaround of downloading the zip the CI server uses. I mentioned updating it on IRC in the same conversation, but that doesn't seem to have happened yet, so I figured I'd open an issue. I believe it is correct for x64, but haven't tried.
The text was updated successfully, but these errors were encountered: