Skip to content

nightly-rust beta regression (via slog-async-2.0.1) #43686

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
est31 opened this issue Aug 5, 2017 · 8 comments
Closed

nightly-rust beta regression (via slog-async-2.0.1) #43686

est31 opened this issue Aug 5, 2017 · 8 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@est31
Copy link
Member

est31 commented Aug 5, 2017

slog-async version 2.0.1 regressed from stable to beta (full log):

Aug 04 12:03:37.632 INFO kablam! error: type `slog::NeverStruct` is private
Aug 04 12:03:37.632 INFO kablam!    --> /cargo-home/registry/src/github.heygears.com-1ecc6299db9ec823/slog-async-2.0.1/lib.rs:178:1
Aug 04 12:03:37.633 INFO kablam!     |
Aug 04 12:03:37.633 INFO kablam! 178 | / pub struct AsyncCoreBuilder<D>
Aug 04 12:03:37.633 INFO kablam! 179 | |     where D: slog::Drain<Err = slog::Never, Ok = ()> + Send + 'static
Aug 04 12:03:37.634 INFO kablam! 180 | | {
Aug 04 12:03:37.634 INFO kablam! 181 | |     chan_size: usize,
Aug 04 12:03:37.635 INFO kablam! 182 | |     drain: D,
Aug 04 12:03:37.635 INFO kablam! 183 | | }
Aug 04 12:03:37.635 INFO kablam!     | |_^

cc @dpc

Also broke @mgattozzi 's https://github.com/mgattozzi/nightly-rust at commit https://github.com/mgattozzi/nightly-rust/commit/35b0a2d6d2adb7d60291e41833f2ab3e0c33439e

@arielb1
Copy link
Contributor

arielb1 commented Aug 5, 2017

Fixed in slog 2.0.6. Old dependency.

@arielb1 arielb1 added regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 5, 2017
@dpc
Copy link
Contributor

dpc commented Aug 5, 2017

Does it mean we can close?

@arielb1
Copy link
Contributor

arielb1 commented Aug 5, 2017

@mgattozzi's program will be broken until he updates his Cargo.lock. Waiting to a response from him.

@arielb1 arielb1 changed the title slog-async-2.0.1 beta regression nightly-rust beta regression (via slog-async-2.0.1) Aug 5, 2017
@dpc
Copy link
Contributor

dpc commented Aug 5, 2017

Oh. I thought this issue is filled against slog.

@mgattozzi
Copy link
Contributor

@arielb1 I haven't had to update it in awhile since I haven't had to update the bot in forever. A testament to Rust's stability. I can update the program and push a change.

@mgattozzi
Copy link
Contributor

Updated the code so the fix is in. Thanks for the notification.
https://github.com/mgattozzi/nightly-rust/commit/af4b8c7c6477f2f16cd08bd8b85f788ccba4c105

If this issue isn't needed anymore I think you can close this.

@est31
Copy link
Member Author

est31 commented Aug 6, 2017

@mgattozzi thanks!

@est31 est31 closed this as completed Aug 6, 2017
@mgattozzi
Copy link
Contributor

You're welcome @est31!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants