Skip to content

Extend rustc_on_unimplemented to query for closures #48534

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
estebank opened this issue Feb 25, 2018 · 0 comments
Open

Extend rustc_on_unimplemented to query for closures #48534

estebank opened this issue Feb 25, 2018 · 0 comments
Labels
A-closures Area: Closures (`|…| { … }`) A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@estebank
Copy link
Contributor

Add a filter to rustc_on_unimplemented to allow the querying for the existence of a closure in the requirement chain. This should allow handling #24909 and #33307 by providing a specific message recommending marking the closure as move.
@estebank estebank added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-diagnostics Area: Messages for errors, warnings, and lints labels Feb 25, 2018
@estebank estebank mentioned this issue Feb 25, 2018
Merged
@jonas-schievink jonas-schievink added A-closures Area: Closures (`|…| { … }`) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 20, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-closures Area: Closures (`|…| { … }`) A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@estebank @jonas-schievink