Skip to content

Remove record_exports pass from resolve #4953

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
catamorphism opened this issue Feb 15, 2013 · 5 comments
Closed

Remove record_exports pass from resolve #4953

catamorphism opened this issue Feb 15, 2013 · 5 comments
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@catamorphism
Copy link
Contributor

This should be no longer needed, but when I tried to remove it, it broke everything.
@msullivan
Copy link
Contributor

The fixme says

    // FIXME #4953 This pass will be removed once exports change to per-item.
    // Then this operation can simply be performed as part of item (or import)
    // processing.

Have we changed exports to per item?

@catamorphism
Copy link
Contributor Author

@msullivan Yes.

@msullivan
Copy link
Contributor

Trying to just remove record_exports still breaks everything.

@huonw
Copy link
Member

huonw commented Jan 19, 2014

Still an issue.

@steveklabnik
Copy link
Member

Triage: still an issue

@bors bors closed this as completed in a353490 Jan 15, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @msullivan @catamorphism @huonw