Skip to content

Schouldn't File::sync_all uselibc::fcntl(fd, libc::F_FULLFSYNC) on macos/ios #55920

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
rustonaut opened this issue Nov 13, 2018 · 0 comments
Closed

Schouldn't File::sync_all uselibc::fcntl(fd, libc::F_FULLFSYNC) on macos/ios #55920

rustonaut opened this issue Nov 13, 2018 · 0 comments
Labels
O-ios Operating system: iOS O-macos Operating system: macOS T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@rustonaut
Copy link

As far as I know fsync doens't sync data onto disk on macos.
(Depending on kernel & file system it might not do so on linux either).

Which is why sync_data does use fcntl on mac for sync_data
and sync_all implies syncing data, so shouldn't it use fcntl, too?
@nagisa nagisa added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. O-macos Operating system: macOS O-ios Operating system: iOS labels Nov 17, 2018
@bors bors closed this as completed in d602a6b Apr 23, 2019
@probablykasper probablykasper mentioned this issue Feb 8, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
O-ios Operating system: iOS O-macos Operating system: macOS T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nagisa @rustonaut and others