Skip to content

beta regression: gltf-viewer ambiguous imports #56316

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
alexcrichton opened this issue Nov 28, 2018 · 2 comments
Closed

beta regression: gltf-viewer ambiguous imports #56316

alexcrichton opened this issue Nov 28, 2018 · 2 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@alexcrichton
Copy link
Member

Discovered by crater:

$ git clone https://github.com/bwasty/gltf-viewer
$ cd gltf-viewer
$ cargo +beta build

cc @petrochenkov

@alexcrichton alexcrichton added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Nov 28, 2018
@alexcrichton alexcrichton added this to the Rust 2018 Release milestone Nov 28, 2018
@petrochenkov
Copy link
Contributor

This is an expected bug-fix regression, it was previously found by the crater run in #55884 as well.
It has a dedicated test - https://github.com/rust-lang/rust/blob/master/src/test/ui/imports/issue-55884-1.rs.

@alexcrichton
Copy link
Member Author

👍

cc @bwasty just to make sure you're aware!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants