-
Notifications
You must be signed in to change notification settings - Fork 13.4k
No nightly on 2018-12-07 #56586
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
@RalfJung or @oli-obk was miri force-pushed recently perhaps? |
No, but I made a PR updating miri to a commit that's in a miri PR, not in miri master. Because GH adds PR commits to the target repo I thought that should work, and it did work locally and on CI. I now made a branch in the miri repo containing that commit, I don't know if having it in a branch vs. a PR makes a difference though (I think it should not). Is the release machine using an ancient version of git? Seems like the same problem that @jethrogb had (#56307 (comment)) with git 2.7 (which is almost 3 years old). |
This should sort itself out then, now that the commit is available upstream, no? But yeah, it would be good if such things were caught in CI. I think it would be reasonable to configure git in the most conservative way w.r.t. finding commits. |
Now that is strange. I don't have this issue.
How do you reproduce this? |
|
We got a nightly last night, so closing! I think this is otherwise diagnosed and being fixed |
As you can see, the latest nightly still has a commit dating from 2018-12-05, meaning it is the nightly created on 2018-12-06 (shortly after midnight). There was no nightly created today.
Cc @rust-lang/infra
The text was updated successfully, but these errors were encountered: