Skip to content

rustc should output a warning when it encounters problems locating cross-crate sources for error messages #56860

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
infinity0 opened this issue Dec 15, 2018 · 2 comments
Open

rustc should output a warning when it encounters problems locating cross-crate sources for error messages #56860

infinity0 opened this issue Dec 15, 2018 · 2 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@infinity0
Copy link
Contributor

See #53081 - currently it is hard to diagnose what path it is actually looking for.

Problems might include:

  • can't find the file
  • the file has the wrong hash.
@infinity0 infinity0 mentioned this issue Dec 15, 2018
Closed
@eddyb
Copy link
Member

eddyb commented Dec 15, 2018

cc @michaelwoerister @nikomatsakis

Not finding the file would be far too common IMO (any system-wide Rust installation pretty much defaults to that), but the file being there and not matching the hash is potentially doable.

@infinity0
Copy link
Contributor Author

infinity0 commented Dec 15, 2018 •
edited
Loading

It would be one extra line on top of an already-existing 4-line warning, and can help people realise what's missing if the diagnostic message contains the path being searched for. Maybe guard it behind --verbose if it's really considered too spammy?

@jonas-schievink jonas-schievink added the A-diagnostics Area: Messages for errors, warnings, and lints label Jan 26, 2019
@crlf0710 crlf0710 added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 11, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eddyb @infinity0 @crlf0710 @jonas-schievink