Skip to content

Incorrect source file paths for inlined stdlib code #57191

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
rocallahan opened this issue Dec 29, 2018 · 3 comments
Closed

Incorrect source file paths for inlined stdlib code #57191

rocallahan opened this issue Dec 29, 2018 · 3 comments

Comments

@rocallahan
Copy link

This seems related to #34179 ... CCing @luser @tromey.

I did cargo new --bin test_crate; cd test_crate; cargo build; objdump --dwarf=rawline target/debug/test_crate. The output for the first compilation unit has

 The Directory Table (offset 0x1c):
  1     libstd/sys/unix/process
  2     src

 The File Name Table (offset 0x39):
  Entry Dir     Time    Size    Name
  1     1       0       0       process_common.rs
  2     2       0       0       main.rs

If I understand #34187 correctly the intent was that the stdlib code (process_common.rs in this case) should have been given an absolute path, since test_crate/libstd/sys/unix/process/process_common.rs certainly doesn't exist. But here we are. rustc 1.31.1 (b6c32da9b 2018-12-18).

@Centril
Copy link
Contributor

Centril commented Dec 29, 2018

cc @alexcrichton

@luser
Copy link
Contributor

luser commented Dec 31, 2018

This is probably a dupe of #54408 which was fixed in #54626 . We noticed this in Firefox crash reports as well. It should be fixed on beta.

@rocallahan
Copy link
Author

Ah yes, it's fixed on nightly. Sorry, I should have tested that before filing. Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants