Skip to content

mingw-check job is building the compiler, not just checking #58410

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
scottmcm opened this issue Feb 12, 2019 · 4 comments
Closed

mingw-check job is building the compiler, not just checking #58410

scottmcm opened this issue Feb 12, 2019 · 4 comments
Labels
C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@scottmcm
Copy link
Member

Example: https://travis-ci.com/rust-lang/rust/jobs/177017513

1298:   Checking compiler artifacts (x86_64-unknown-linux-gnu -> i686-pc-windows-gnu)
1502:   Building stage0 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)

This is costing an extra ~18 minutes of travis time per PR build (maybe more).

cc @kennytm who I talked with on Discord about this

@scottmcm scottmcm added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Feb 12, 2019
@phansch
Copy link
Member

phansch commented Feb 12, 2019

I added this in #57010. Is there some way to avoid building the full compiler for these tests or would it make sense to move this to another job?

@Mark-Simulacrum
Copy link
Member

There should be a way -- IIRC we should be building compile test without building the compiler at all (i.e., using the bootstrap compiler).

@scottmcm scottmcm added the C-bug Category: This is a bug. label Feb 13, 2019
@mati865
Copy link
Contributor

mati865 commented Apr 19, 2019

@scottmcm I believe it's fixed, here is latest mingw-check job: https://travis-ci.com/rust-lang/rust/jobs/194269571

@scottmcm
Copy link
Member Author

Agreed. Thanks, @mati865!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants