Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add optional span to require_lang_item for diagnostics with more context #63954

Closed
estebank opened this issue Aug 27, 2019 · 0 comments · Fixed by #63961
Closed

Add optional span to require_lang_item for diagnostics with more context #63954

estebank opened this issue Aug 27, 2019 · 0 comments · Fixed by #63961
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-lang-item Area: Language items C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@estebank
Copy link
Contributor

fn require_lang_item(LangItem) should also take an optional Span to avoid output without context.
@estebank estebank added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-lang-item Area: Language items labels Aug 27, 2019
@jonas-schievink jonas-schievink added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Aug 27, 2019
@JohnTitor JohnTitor mentioned this issue Aug 27, 2019
Merged
@bors bors closed this as completed in d4757d5 Aug 29, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-lang-item Area: Language items C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Option<Span> to require_lang_item JohnTitor/rust
2 participants
@estebank @jonas-schievink