Skip to content

miri no longer builds after rust-lang/rust#66275 #67022

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
rust-highfive opened this issue Dec 4, 2019 · 2 comments · Fixed by #67038
Closed

miri no longer builds after rust-lang/rust#66275 #67022

rust-highfive opened this issue Dec 4, 2019 · 2 comments · Fixed by #67038
Assignees
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Contributor

Hello, this is your friendly neighborhood mergebot.
After merging PR #66275, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @oli-obk, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @RalfJung, the PR reviewer, and nominating for compiler team prioritization.

@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 4, 2019
@RalfJung
Copy link
Member

RalfJung commented Dec 4, 2019

Cc @eddyb

The error is

error: internal compiler error: src/librustc_typeck/collect.rs:1869: to get the signature of a closure, use `closure_sig()` not `fn_sig()`

with the following backtrace

  19: rustc::util::bug::bug_fmt
  20: rustc_typeck::collect::fn_sig
  21: rustc::ty::query::__query_compute::fn_sig
  22: rustc::ty::query::<impl rustc::ty::query::config::QueryAccessors for rustc::ty::query::queries::fn_sig>::compute
  23: rustc::dep_graph::graph::DepGraph::with_task_impl
  24: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt>::get_query
  25: rustc::ty::constness::provide::is_const_fn_raw
  26: rustc::ty::query::<impl rustc::ty::query::config::QueryAccessors for rustc::ty::query::queries::is_const_fn_raw>::compute::{{closure}}
             at /rustc/7fa046534e944193cc47b795b9396a7fcf411d9f/src/librustc/ty/query/plumbing.rs:984
  27: rustc::ty::query::__query_compute::is_const_fn_raw
             at /rustc/7fa046534e944193cc47b795b9396a7fcf411d9f/src/librustc/ty/query/plumbing.rs:935

@RalfJung
Copy link
Member

RalfJung commented Dec 4, 2019

Ah but further up the call stack we have

  46: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt>::get_query
             at /rustc/7fa046534e944193cc47b795b9396a7fcf411d9f/src/librustc/ty/query/plumbing.rs:376
  47: rustc::ty::query::TyCtxtAt::is_const_fn_raw
             at /rustc/7fa046534e944193cc47b795b9396a7fcf411d9f/src/librustc/ty/query/plumbing.rs:1061
  48: rustc_mir::interpret::terminator::<impl rustc_mir::interpret::eval_context::InterpCx<M>>::eval_fn_call
             at /rustc/7fa046534e944193cc47b795b9396a7fcf411d9f/src/librustc_mir/interpret/terminator.rs:274
  49: rustc_mir::interpret::terminator::<impl rustc_mir::interpret::eval_context::InterpCx<M>>::eval_terminator
             at /rustc/7fa046534e944193cc47b795b9396a7fcf411d9f/src/librustc_mir/interpret/terminator.rs:83
  50: rustc_mir::interpret::step::<impl rustc_mir::interpret::eval_context::InterpCx<M>>::terminator
             at /rustc/7fa046534e944193cc47b795b9396a7fcf411d9f/src/librustc_mir/interpret/step.rs:303
  51: rustc_mir::interpret::step::<impl rustc_mir::interpret::eval_context::InterpCx<M>>::step
             at /rustc/7fa046534e944193cc47b795b9396a7fcf411d9f/src/librustc_mir/interpret/step.rs:78
  52: rustc_mir::interpret::step::<impl rustc_mir::interpret::eval_context::InterpCx<M>>::run
             at /rustc/7fa046534e944193cc47b795b9396a7fcf411d9f/src/librustc_mir/interpret/step.rs:40

so I think this will be fixed by #66866

@RalfJung RalfJung mentioned this issue Dec 4, 2019
@bors bors closed this as completed in aeaaf8f Dec 5, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants