Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Broken tool going into toolstate week blocks PRs from landing #68458

Closed
Centril opened this issue Jan 22, 2020 · 0 comments · Fixed by #69624
Closed

Broken tool going into toolstate week blocks PRs from landing #68458

Centril opened this issue Jan 22, 2020 · 0 comments · Fixed by #69624
Assignees
@Mark-Simulacrum
Labels
T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented Jan 22, 2020

Despite Clippy already being broken in toolstate, #68432 (comment) failed to land due to Clippy not passing.

We had to fix clippy in #68442 so that PRs could start landing again.

It's unclear whether this is intentional or not.

Relevant discussion: https://discordapp.com/channels/442252698964721669/443148319431065610/669558059831394346.
@Centril Centril added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Jan 22, 2020
@ehuss ehuss mentioned this issue Mar 1, 2020
Merged
@bors bors closed this as completed in f8fb3ef Mar 2, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Toolstate: Don't block beta week on already broken tools. ehuss/rust
2 participants
@Centril @Mark-Simulacrum