Skip to content

When errors have been emitted, do not continue to codegen stage #69786

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
estebank opened this issue Mar 6, 2020 · 0 comments
Open

When errors have been emitted, do not continue to codegen stage #69786

estebank opened this issue Mar 6, 2020 · 0 comments
Labels
A-codegen Area: Code generation C-optimization Category: An issue highlighting optimization opportunities or PRs implementing such I-slow Issue: Problems and improvements with respect to performance of generated code. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@estebank
Copy link
Contributor

estebank commented Mar 6, 2020

After #60126 we now continue all the way to codegen even in the face of errors. We should stop before codegen as it is a waste of time.
@estebank estebank added I-slow Issue: Problems and improvements with respect to performance of generated code. A-codegen Area: Code generation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 6, 2020
@workingjubilee workingjubilee added C-optimization Category: An issue highlighting optimization opportunities or PRs implementing such and removed C-optimization Category: An issue highlighting optimization opportunities or PRs implementing such labels Feb 14, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation C-optimization Category: An issue highlighting optimization opportunities or PRs implementing such I-slow Issue: Problems and improvements with respect to performance of generated code. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@estebank @workingjubilee