Skip to content

bootstrap: support x.py build src/librustdoc #73439

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
jyn514 opened this issue Jun 17, 2020 · 2 comments · Fixed by #73440
Closed

bootstrap: support x.py build src/librustdoc #73439

jyn514 opened this issue Jun 17, 2020 · 2 comments · Fixed by #73440
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Jun 17, 2020

Current behavior:

thread 'main' panicked at 'Error: no rules matched src/librustdoc.', src/bootstrap/builder.rs:222:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failed to run: /home/joshua/src/rust/build/bootstrap/debug/bootstrap build src/librustdoc

Expected behavior: This builds rustdoc.

I'm interested in working on this, if anyone has suggestions that would be much appreciated. I found src/bootstrap/builder.rs but I'm having a hard time understanding ShouldRun.
@jonas-schievink jonas-schievink added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Jun 17, 2020
@jyn514
Copy link
Member Author

jyn514 commented Jun 17, 2020

It looks like the existing (undocumented) way to do this is x.py build src/tools/rustdoc. I'm going to try and add src/librustdoc as an alias for that (since no one actually works with src/tools/librustdoc, it's almost empty).

@jyn514 jyn514 mentioned this issue Jun 17, 2020
Merged
@jyn514
Copy link
Member Author

jyn514 commented Jun 17, 2020

Ok, undocumented was a lie, it's here, just hard to find: https://rustc-dev-guide.rust-lang.org/rustdoc.html#cheat-sheet

@bors bors closed this as completed in d69d4c3 Jun 20, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add src/librustdoc as an alias for src/tools/rustdoc jyn514/rust
2 participants
@jonas-schievink @jyn514