Skip to content

rls no longer builds after rust-lang/rust#74073 #74080

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
rust-highfive opened this issue Jul 6, 2020 · 3 comments · Fixed by #74760
Closed

rls no longer builds after rust-lang/rust#74073 #74080

rust-highfive opened this issue Jul 6, 2020 · 3 comments · Fixed by #74760
Assignees
Labels
C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Contributor

Hello, this is your friendly neighborhood mergebot.
After merging PR #74073, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @Manishearth, do you think you would have time to do the follow-up work?
If so, that would be great!

And nominating for compiler team prioritization.

@rust-highfive rust-highfive added A-rls C-bug Category: This is a bug. labels Jul 6, 2020
@Manishearth
Copy link
Member

#74073 (comment)

@Xanewok
Copy link
Member

Xanewok commented Jul 13, 2020

Closed via #74240.

@Xanewok Xanewok closed this as completed Jul 13, 2020
@tmandry
Copy link
Member

tmandry commented Jul 22, 2020

The build appears to be broken still. I'm seeing the following failure:

error[E0635]: unknown feature `const_transmute`
  --> /home/swarming/.cargo/registry/src/github.heygears.com-1ecc6299db9ec823/rustc-ap-rustc_ast-664.0.0/lib.rs:13:12
   |
13 | #![feature(const_transmute)]
   |            ^^^^^^^^^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0635`.
error: could not compile `rustc-ap-rustc_ast`.

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed
command did not execute successfully: "/b/s/w/ir/k/recipe_cleanup/rustLjFjLE/build/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "32" "--release" "--manifest-path" "/b/s/w/ir/k/rust/src/tools/rls/Cargo.toml" "--features" "clippy, rustc-workspace-hack/all-static" "--message-format" "json-render-diagnostics"
expected success, got: exit code: 101
thread 'main' panicked at 'Unable to build RLS', src/bootstrap/dist.rs:66:9

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants