Skip to content

The rust-src component contains a symlink #74624

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
RalfJung opened this issue Jul 22, 2020 · 4 comments
Closed

The rust-src component contains a symlink #74624

RalfJung opened this issue Jul 22, 2020 · 4 comments
Labels
C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@RalfJung
Copy link
Member

RalfJung commented Jul 22, 2020 •
edited
Loading

Extracting the rust-src component with rustup-toolchain-install-master fails because there is a symlink in that component (kennytm/rustup-toolchain-install-master#39). The symlink was introduced some time between 567ad74 and 734233d.

The tool should be fixed, but I wonder -- is that expected? Not all filesystems support symlinks (AFAIK this is a problem on Windows), and so far it seems like there were no symlinks.
@jonas-schievink jonas-schievink added C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 22, 2020
@Mark-Simulacrum
Copy link
Member

I think this was fixed in #74578.

@RalfJung
Copy link
Member Author

It was indeed, thanks!

@RalfJung
Copy link
Member Author

RalfJung commented Jul 22, 2020 •
edited
Loading

This is unfortunate though as it landed after the other PR that broke Miri again recently (#69749)... making it now 4 days straight during which it was impossible to build Miri against rustc master. We keep fixing things but new breakage is landing before the fixes make it through.^^

@Mark-Simulacrum
Copy link
Member

Yeah we're reverting gimli entirely in a bit (hopefully not rebreaking anything) but next time we land it I plan to do some try-testing to make sure it's not breaking rustup etc.

I also hope to add tests that we don't have symlinks to our dist builders.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RalfJung @jonas-schievink @Mark-Simulacrum