Skip to content

linkchecker is not catching some broken links #80175

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
jyn514 opened this issue Dec 19, 2020 · 4 comments
Open

linkchecker is not catching some broken links #80175

jyn514 opened this issue Dec 19, 2020 · 4 comments
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug.

Comments

@jyn514
Copy link
Member

jyn514 commented Dec 19, 2020

https://doc.rust-lang.org/nightly/std/primitive.slice.html#method.concat-2 links to https://doc.rust-lang.org/std/primitive.slice.html#method.concat, which does not exist in the build directory, only on the website itself (it's linking to the stable docs instead of nightly).

Source code:

/// Helper trait for [`[T]::concat`](../../std/primitive.slice.html#method.concat).
,
/// Implementation of [`[T]::concat`](../../std/primitive.slice.html#method.concat)

Caught by cargo-deadlinks: deadlinks/cargo-deadlinks#133 (comment)

@jyn514 jyn514 added A-testsuite Area: The testsuite used to check the correctness of rustc A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. labels Dec 19, 2020
@jyn514
Copy link
Member Author

jyn514 commented Dec 19, 2020

I expect this will break when promoted to the stable channel, it only works by coincidence now. I think it works because ../../ on the root directory stays as the root directory.

@jyn514
Copy link
Member Author

jyn514 commented Dec 19, 2020

Hmm, I'm not actually sure this can be fixed without intra-doc links: Concat appears in std::slice::Concat which does need both ../../. I guess since this is harmless it doesn't actually need to be fixed?

cc #63351

@jyn514
Copy link
Member Author

jyn514 commented Jan 8, 2021

This can be fixed after the beta bump now that #80181 is merged.

@hkBst
Copy link
Member

hkBst commented Jan 30, 2025

Is this still an issue?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants