Skip to content

str::as_bytes and friends have incorrect const stabilization version annotation #82085

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
tbu- opened this issue Feb 14, 2021 · 2 comments · Fixed by #83053
Closed

str::as_bytes and friends have incorrect const stabilization version annotation #82085

tbu- opened this issue Feb 14, 2021 · 2 comments · Fixed by #83053
Assignees
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@tbu-
Copy link
Contributor

tbu- commented Feb 14, 2021

#[rustc_const_stable(feature = "str_as_bytes", since = "1.32.0")]

These were stabilized in 7767e7f as part of #63770 which was only included in 1.39.0 and up (GitHub displays this in the commit link).

The attribute was added in 5e17e39 as part of #67136, one could presumably check the other version attributes as well.

Affects:

  • str::as_bytes
  • str::is_empty
  • str::len
@m-ou-se
Copy link
Member

m-ou-se commented Feb 14, 2021

cc @oli-obk

@oli-obk
Copy link
Contributor

oli-obk commented Feb 14, 2021

I just copy pasted these everywhere and forgot to check the versions on some of these. I guess I'll have to go through all of them to find out which ones I missed.

@camelid camelid added C-bug Category: This is a bug. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Feb 26, 2021
@bors bors closed this as completed in f826641 Mar 21, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants