Skip to content

Invalid suggestion for panic![123] #82111

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
m-ou-se opened this issue Feb 14, 2021 · 1 comment · Fixed by #82113
Closed

Invalid suggestion for panic![123] #82111

m-ou-se opened this issue Feb 14, 2021 · 1 comment · Fixed by #82113
Assignees
@m-ou-se
Labels
A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` D-invalid-suggestion Diagnostics: A structured suggestion resulting in incorrect code.

Comments

@m-ou-se
Copy link
Member

m-ou-se commented Feb 14, 2021

The non_fmt_panic lint now suggests to replace panic![123] by std::panic::panic_any(123]. Calling the panic macro with [] or {} is uncommon, but it'd be good if it doesn't suggest invalid code.
@m-ou-se m-ou-se added A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` D-invalid-suggestion Diagnostics: A structured suggestion resulting in incorrect code. labels Feb 14, 2021
@m-ou-se m-ou-se self-assigned this Feb 14, 2021
@m-ou-se
Copy link
Member Author

m-ou-se commented Feb 14, 2021

A problem here is that panic! { 123 } doesn't need a ;, while panic_any(123) might need a ; in that same context, depending on the context. It's probably not worth solving this case though.

@m-ou-se m-ou-se mentioned this issue Feb 14, 2021
Merged
@bors bors closed this as completed in 547b3ad Feb 23, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@m-ou-se m-ou-se

Labels
A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` D-invalid-suggestion Diagnostics: A structured suggestion resulting in incorrect code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve non_fmt_panic lint. m-ou-se/rust
1 participant
@m-ou-se