Skip to content

./x.py clippy builds llvm #85047

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
matthiaskrgr opened this issue May 7, 2021 · 5 comments
Closed

./x.py clippy builds llvm #85047

matthiaskrgr opened this issue May 7, 2021 · 5 comments
Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust C-bug Category: This is a bug. E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@matthiaskrgr
Copy link
Member

./x.py clippy builds llvm for some reason while ./x.py check does not.

https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/x.2Epy.20clippy.20builds.20llvm

repo @ e5f83d2

@matthiaskrgr matthiaskrgr added the C-bug Category: This is a bug. label May 7, 2021
@jyn514 jyn514 added A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 7, 2021
@jyn514
Copy link
Member

jyn514 commented May 7, 2021

I can't replicate this.

> rm -r build/x86_64-unknown-linux-gnu/llvm/
> x clippy
Updating only changed submodules
Submodules updated in 0.01 seconds
    Finished dev [unoptimized + debuginfo] target(s) in 0.09s
Checking stage0 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Checking core v0.0.0 (/home/joshua/rustc/library/core)
warning: this `if` has identical blocks
  --> library/unwind/build.rs:13:5
   |
13 | /     {
14 | |         // Build the unwinding from libunwind C/C++ source code.
15 | |         llvm_libunwind::compile();
16 | |     } else if target.contains("x86_64-fortanix-unknown-sgx") {
   | |_____^

Are you running into #84938 maybe?

@matthiaskrgr
Copy link
Member Author

I had it happen to me that after not running x.py build for a while, x.py check would not build llvm but x.py clippy did, mmh.

I have ninja installed and didn't see any errors around that.

@jyn514
Copy link
Member

jyn514 commented May 7, 2021

Can you post the full output of x.py clippy up until you see CMake output?

@jyn514 jyn514 added the E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example label May 7, 2021
@jyn514
Copy link
Member

jyn514 commented Jun 4, 2021

@matthiaskrgr are you still running into this? I can't fix it if I don't know what's wrong.

@jyn514
Copy link
Member

jyn514 commented Jul 11, 2022

I'm going to close this since I haven't been able to reproduce. In practice this should have much less of an impact than it used to since we download LLVM most of the time.

@jyn514 jyn514 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust C-bug Category: This is a bug. E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

2 participants