Skip to content

Debuginfo for windows-msvc treats () as tuple$<> #89704

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wesleywiser opened this issue Oct 9, 2021 · 0 comments
Open

Debuginfo for windows-msvc treats () as tuple$<> #89704

wesleywiser opened this issue Oct 9, 2021 · 0 comments
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-enhancement Category: An issue proposing an enhancement or a PR with one. O-windows-msvc Toolchain: MSVC, Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@wesleywiser
Copy link
Member

@michaelwoerister found, debuginfo for the windows-msvc targets currently names the () type as tuple$<>. We should probably try to name the unit type () for consistency with Rust.

Relatedly, it may make sense to have natvis which sets a <DisplayString /> for ZSTs to just the type name.
@wesleywiser wesleywiser added A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-enhancement Category: An issue proposing an enhancement or a PR with one. O-windows-msvc Toolchain: MSVC, Operating system: Windows labels Oct 9, 2021
@wesleywiser wesleywiser mentioned this issue Jan 31, 2022
Merged
@Noratrieb Noratrieb added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-enhancement Category: An issue proposing an enhancement or a PR with one. O-windows-msvc Toolchain: MSVC, Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wesleywiser @Noratrieb