Skip to content

regression: alloc::prelude removed #90322

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
Mark-Simulacrum opened this issue Oct 26, 2021 · 8 comments
Closed

regression: alloc::prelude removed #90322

Mark-Simulacrum opened this issue Oct 26, 2021 · 8 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone

Comments

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Oct 26, 2021

#89898 removed alloc::prelude, which was unstable, but some crates depended on it with absolute paths (which is a known stability hole):

@Mark-Simulacrum Mark-Simulacrum added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Oct 26, 2021
@Mark-Simulacrum Mark-Simulacrum added this to the 1.57.0 milestone Oct 26, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Oct 26, 2021
@Mark-Simulacrum
Copy link
Member Author

I think we likely want to just close this but wanted to file it for awareness, but I don't expect even a relnotes inclusion since it's a pretty clear use of an unstable feature.

@nbdd0121
Copy link
Contributor

How many crates are affected?

@Mark-Simulacrum
Copy link
Member Author

1 -- with the usual caveat of "that Crater detected". But I expect breakage to be minimal, and the migration to a stable path for any affected uses should be fairly easy.

@jhpratt
Copy link
Member

jhpratt commented Oct 27, 2021

Given that this is only a single known crate with 90 all-time downloads, I'm inclined to close this as well. Unstable APIs are unstable for a reason.

That said, what can be done about this stability hole? I just checked the source code for the crate and it doesn't do anything out of the ordinary. Is there documentation of this bug somewhere?

@nbdd0121
Copy link
Contributor

It's #15702

@jhpratt
Copy link
Member

jhpratt commented Oct 27, 2021

Wow, that's an old issue.

@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Oct 27, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Oct 27, 2021

Closing this, as the impact seems very minimal. A solution for #15702 would be nice.

@m-ou-se m-ou-se closed this as completed Oct 27, 2021
@Mark-Simulacrum
Copy link
Member Author

no-proto is also broken, cc @only-cliches -- discovered in the rustdoc crater run.

https://crater-reports.s3.amazonaws.com/beta-1.57-rustdoc-1/beta-2021-10-22/reg/no_proto-0.9.60/log.txt

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants