Skip to content

mobile: tapping outside the sidebar should close it #92682

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
jsha opened this issue Jan 9, 2022 · 1 comment · Fixed by #92803
Closed

mobile: tapping outside the sidebar should close it #92682

jsha opened this issue Jan 9, 2022 · 1 comment · Fixed by #92803
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jsha
Copy link
Contributor

jsha commented Jan 9, 2022

Steps to reproduce:

  1. On mobile, tap the upper-left hamburger icon to open the sidebar menu.
  2. Tap somewhere on the right side of the screen (e.g. the search bar).

Expected result:

Sidebar closes.

Actual result:

Sidebar doesn't close.
@jsha jsha added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Jan 9, 2022
@jsha
Copy link
Contributor Author

jsha commented Jan 12, 2022

Also, relatedly: Clicking a link in the sidebar that goes to the same doc (for instance, methods on a struct page) should close the sidebar.

@jsha jsha mentioned this issue Jan 12, 2022
Merged
@bors bors closed this as completed in cc2339c Jan 18, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide mobile sidebar on some clicks jsha/rust
1 participant
@jsha