Skip to content

regression: abs_diff parameter types #94504

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
Mark-Simulacrum opened this issue Mar 1, 2022 · 1 comment
Closed

regression: abs_diff parameter types #94504

Mark-Simulacrum opened this issue Mar 1, 2022 · 1 comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Milestone

Comments

@Mark-Simulacrum
Copy link
Member

Crater picked up this issue in a number of crates:

cc #89492 (tracking issue, should probably be closed as feature is stable?)

[INFO] [stdout] error[E0308]: mismatched types
[INFO] [stdout]  --> src/types/tests.rs:7:32
[INFO] [stdout]   |
[INFO] [stdout] 7 |     expect_that!(&1i8.abs_diff(&0i8), is(equal_to(1i8)));
[INFO] [stdout]   |                                ^^^^ expected `i8`, found `&i8`
[INFO] [stdout]   |
[INFO] [stdout] help: consider removing the borrow
[INFO] [stdout]   |
[INFO] [stdout] 7 -     expect_that!(&1i8.abs_diff(&0i8), is(equal_to(1i8)));
[INFO] [stdout] 7 +     expect_that!(&1i8.abs_diff(0i8), is(equal_to(1i8)));
[INFO] [stdout]   | 
@Mark-Simulacrum Mark-Simulacrum added regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs Relevant to the library team, which will review and decide on the PR/issue. I-libs-nominated Nominated for discussion during a libs team meeting. labels Mar 1, 2022
@Mark-Simulacrum Mark-Simulacrum added this to the 1.60.0 milestone Mar 1, 2022
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Mar 1, 2022
@m-ou-se
Copy link
Member

m-ou-se commented Mar 2, 2022

Discucssed this in the libs meeting. Closing this as expected and acceptable breakage.

@m-ou-se m-ou-se closed this as completed Mar 2, 2022
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Mar 2, 2022
@dtolnay dtolnay removed the I-libs-nominated Nominated for discussion during a libs team meeting. label Sep 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants