#[repr(transparent)] in sys::windows::os_str::Slice

[JanBeh]

I noticed that the sys::windows::os_str::Slice type is not repr(transparent) while sys::unix::os_str::Slice is. However, they are required to have a transparent representation.

While the standard library may(?) assume they will properly transmute, it might be better to add #[repr(transparent)] to sys::windows::os_str::Slice. Possibly this affects other systems as well.

See also this thread/post on URLO.

[ChrisDenton]

Note that making the Unix version transparent was a relatively recent change (May of last year). The reason given was:

Because Buf and Slice now no longer live in a publicly exported module they can be marked as pub and repr(transparent) as normal.

[ghost]

@rustbot claim