Skip to content

Don't export no_mangle symbols from proc macros #99978

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
bjorn3 opened this issue Jul 31, 2022 · 2 comments · Fixed by #114470
Closed

Don't export no_mangle symbols from proc macros #99978

bjorn3 opened this issue Jul 31, 2022 · 2 comments · Fixed by #114470
Labels
A-proc-macros Area: Procedural macros I-heavy Issue: Problems and improvements with respect to binary size of generated code. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@bjorn3
Copy link
Member

bjorn3 commented Jul 31, 2022

#99944 will hide all non-no_mangle symbols, but given that proc macros will only be loaded by rustc, we can hide all symbols except the specific ones that rustc needs.
@bjorn3 bjorn3 added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. I-heavy Issue: Problems and improvements with respect to binary size of generated code. A-proc-macros Area: Procedural macros labels Jul 31, 2022
@bjorn3 bjorn3 mentioned this issue Jul 31, 2022
Merged
@bjorn3
Copy link
Member Author

bjorn3 commented Dec 1, 2022

Fixed by #99944

@bjorn3 bjorn3 closed this as completed Dec 1, 2022
@bjorn3
Copy link
Member Author

bjorn3 commented Dec 1, 2022

Actually, I need to check if it is actually fixed. Will reopen until I have verified it.

@bjorn3 bjorn3 reopened this Dec 1, 2022
@bjorn3 bjorn3 mentioned this issue Jul 20, 2023
Closed
@pnkfelix pnkfelix mentioned this issue Aug 4, 2023
Merged
@bors bors closed this as completed in a946c1e Aug 9, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-proc-macros Area: Procedural macros I-heavy Issue: Problems and improvements with respect to binary size of generated code. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restrict linker version script of proc-macro crates to just its two symbols pnkfelix/rust
1 participant
@bjorn3