Skip to content

Fix invalid HTML DIV tag used in HEAD #113094

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2023
Merged

Fix invalid HTML DIV tag used in HEAD #113094

merged 2 commits into from
Jun 28, 2023

Conversation

GuillaumeGomez
Copy link
Member

Fixes #113067.

The issue also nicely explains the whole problem.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 27, 2023
@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 27, 2023

📌 Commit b8e4c54 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2023
@fmease
Copy link
Member

fmease commented Jun 27, 2023

Having <meta> without name is non-standard though, did I read that right?

Exactly one of the name, http-equiv, charset, and itemprop attributes must be specified.

https://html.spec.whatwg.org/multipage/semantics.html#the-meta-element

@GuillaumeGomez
Copy link
Member Author

It says just below that we can add our own: https://html.spec.whatwg.org/multipage/semantics.html#other-metadata-names

@notriddle
Copy link
Contributor

So the id should be converted to name?

@fmease
Copy link
Member

fmease commented Jun 27, 2023 •
edited
Loading

It says just below that we can add our own: [link]

Well yeah but this meta element doesn't have any name attribute, so this section doesn't apply. It means though that you could add a name="some_custom_name" that'd work.

Do we strive for standard compliance actually? I don't know. In this specific case it doesn't matter obviously.

Edit: Ah, just saw notriddle's comment above, the GitHub mobile app didn't load it for me.

@GuillaumeGomez
Copy link
Member Author

I use the html-checker tool to ensure it's "okay enough". But if we want to be fully compliant, I don't mind replacing id with name.

@fmease
Copy link
Member

fmease commented Jun 27, 2023 •
edited
Loading

I don't want to be pedantic and hold things back. I'd say go with name over id but do however you please :)

@GuillaumeGomez
Copy link
Member Author

Let's use name then. :)

TaKO8Ki added a commit to TaKO8Ki/rust that referenced this pull request Jun 27, 2023
@TaKO8Ki
Rollup merge of rust-lang#113094 - GuillaumeGomez:fix-invalid-div-tag…
6e6a1bb 
…-in-head, r=notriddle

Fix invalid HTML DIV tag used in HEAD

Fixes rust-lang#113067.

The issue also nicely explains the whole problem.

r? `@notriddle`
@TaKO8Ki TaKO8Ki mentioned this pull request Jun 27, 2023
Closed
TaKO8Ki added a commit to TaKO8Ki/rust that referenced this pull request Jun 27, 2023
@TaKO8Ki
Rollup merge of rust-lang#113094 - GuillaumeGomez:fix-invalid-div-tag…
0d0361f 
…-in-head, r=notriddle

Fix invalid HTML DIV tag used in HEAD

Fixes rust-lang#113067.

The issue also nicely explains the whole problem.

r? ``@notriddle``
@TaKO8Ki TaKO8Ki mentioned this pull request Jun 27, 2023
Closed
@rustbot
Copy link
Collaborator

rustbot commented Jun 27, 2023

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-log-analyzer

This comment has been minimized.

# to view
@GuillaumeGomez GuillaumeGomez force-pushed the fix-invalid-div-tag-in-head branch from 0b13836 to acbfb8c Compare June 27, 2023 21:22
@GuillaumeGomez
Copy link
Member Author

@bors r=notriddle,fmease rollup

@bors
Copy link
Collaborator

bors commented Jun 27, 2023

📌 Commit acbfb8c has been approved by notriddle,fmease

It is now in the queue for this repository.

@matthiaskrgr matthiaskrgr mentioned this pull request Jun 28, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 28, 2023
@matthiaskrgr
Rollup merge of rust-lang#113094 - GuillaumeGomez:fix-invalid-div-tag…
ddaf616 
…-in-head, r=notriddle,fmease

Fix invalid HTML DIV tag used in HEAD

Fixes rust-lang#113067.

The issue also nicely explains the whole problem.

r? `@notriddle`
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 28, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 28, 2023
@bors
Auto merge of rust-lang#113120 - Dylan-DPC:rollup-cz4qr3o, r=Dylan-DPC
eb76764 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#111571 (Implement proposed API for `proc_macro_span`)
 - rust-lang#112236 (Simplify computation of killed borrows)
 - rust-lang#112867 (More `ImplSource` nits)
 - rust-lang#113019 (add note for non-exhaustive matches with guards)
 - rust-lang#113094 (Fix invalid HTML DIV tag used in HEAD)
 - rust-lang#113111 (add myself to review for t-types stuff)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a70842c into rust-lang:master Jun 28, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 28, 2023
@GuillaumeGomez GuillaumeGomez deleted the fix-invalid-div-tag-in-head branch June 28, 2023 16:17
@apiraino apiraino mentioned this pull request Sep 14, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.

Rustdoc generates invalid HTML header
6 participants
@GuillaumeGomez @notriddle @bors @fmease @rustbot @rust-log-analyzer