Disable jump threading UnOp::Not for non-bool

[compiler-errors]

Fix #131195, where jumpthreading was optimizing !a == b into a != b for non-bool, where this is definitely not true.

[rustbot]

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

[compiler-errors]

I would not be surprised if jumpthreading has more type-based bugs, since we've already found two at this point.

[compiler-errors]

#131203

[compiler-errors]

This is a more conservative fix than #131203, which seems like it still has problems.

[cjgillot]

@bors r+

[bors]

📌 Commit f0bfba2 has been approved by cjgillot

It is now in the queue for this repository.

[bors]

⌛ Testing commit f0bfba2 with merge 11ee3a8...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 11ee3a8 to master...

[rust-timer]

Finished benchmarking commit (11ee3a8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -4.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.2%	[-5.3%, -3.0%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[2.1%, 2.8%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 772.19s -> 772.334s (0.02%)
Artifact size: 342.02 MiB -> 342.01 MiB (-0.00%)

[lqd]

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle.

Stable nomination is also accepted in principle but it's not really needed: the new stable should have this beta backport when the stable artifacts are built in 3 days. Therefore, I'll remove the stable nomination, as it's a no-op this late in the cycle.

@rustbot label +beta-accepted -stable-nominated