make asm diagnostic instruction optional #59242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @nagisa |
|
@bors r+ |
|
📌 Commit 8d64f9c52257f328e2c5986f55a2f86157886dac has been approved by |
bors
added
S-waiting-on-bors
|
@bors r- This PR caused failure in #59397 (comment). Please restrict the new test on x86 and x86_64 only. |
bors
added
S-waiting-on-author
`DiagnosticInfoInlineAsm::getInstruction` may return a null pointer, so the instruction shouldn't be blindly unwrapped.
|
Added an |
|
@bors r=nagisa |
|
📌 Commit 4728433 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-travis, status-appveyor |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DiagnosticInfoInlineAsm::getInstructionmay return a null pointer, sothe instruction shouldn't be blindly unwrapped.
Reopening from #55193. I was unable to trigger the assertion on Windows after rebasing.
Fixes #23458.
Fixes #55216.