Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make PROC_MACRO_DERIVE_RESOLUTION_FALLBACK a hard error #84022

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Make PROC_MACRO_DERIVE_RESOLUTION_FALLBACK a hard error #84022

merged 1 commit into from
Nov 1, 2022

Conversation

Aaron1011
Copy link
Member

r? @ghost

@Aaron1011
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Apr 9, 2021

⌛ Trying commit 191f8a971b06684f802fcc33a2398bd15df8a3ab with merge 96e388c3ccda74650413d435528d8e0ed2872a21...

@bors
Copy link
Contributor

bors commented Apr 9, 2021

☀️ Try build successful - checks-actions
Build commit: 96e388c3ccda74650413d435528d8e0ed2872a21 (96e388c3ccda74650413d435528d8e0ed2872a21)

@Aaron1011
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-84022 created and queued.
🤖 Automatically detected try build 96e388c3ccda74650413d435528d8e0ed2872a21
⚠️ Try build based on commit 2e495d2, but latest commit is 191f8a971b06684f802fcc33a2398bd15df8a3ab. Did you forget to make a new try build?
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Apr 9, 2021
@craterbot
Copy link
Collaborator

🚧 Experiment pr-84022 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-84022 is completed!
📊 90 regressed and 8 fixed (155930 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Apr 29, 2021
@Aaron1011
Copy link
Member Author

Unfortunately, one of the regressions is in the unmaintained crate https://github.com/MaikKlein/enumflags

@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2021
@Dylan-DPC-zz Dylan-DPC-zz added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2021
@Aaron1011
Copy link
Member Author

cc @petrochenkov - I'm not sure how you'd like to move forward with this. We could try to move people off https://github.com/MaikKlein/enumflags before we remove the hack, but that would still result in the crate become unusable (the last update was in 2019, and the repository has been archived).

@petrochenkov
Copy link
Contributor

I'm not sure how you'd like to move forward with this.

Leave it as is for a couple more years?
There's no pressure to remove deprecation lints urgently.
It can also be turned into an error on 2021 edition only in the meantime.

@crlf0710 crlf0710 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 5, 2021
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 22, 2021
@crlf0710
Copy link
Member

crlf0710 commented Jul 9, 2021

@Aaron1011 Do you want to turn this into an error on 2021 and later editions only? Or do you prefer this be closed?

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 25, 2021
@Aaron1011
Copy link
Member Author

@crlf0710 I think that would be reasonable. While this could theoretically break some 2018 edition code in the presence of a sufficiently weird proc-macro (e.g. a proc-macro which marks the input tokens with a 2021 edition span), I think it would be good to make progress on this issue.

@camelid camelid added the I-needs-decision Issue: In need of a decision. label Aug 29, 2021
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 13, 2021
@JohnCSimon JohnCSimon removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 3, 2021
@rfcbot rfcbot added the disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. label Oct 10, 2022
@Aaron1011
Copy link
Member Author

cc @nagisa @estebank @nikomatsakis @pnkfelix for review and checkboxes

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Oct 20, 2022
@rfcbot
Copy link

rfcbot commented Oct 20, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@Aaron1011 Aaron1011 force-pushed the remove-derive-res-fallback branch from 3606629 to 7d82cad Compare October 24, 2022 18:40
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Oct 30, 2022
@rfcbot
Copy link

rfcbot commented Oct 30, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rfcbot rfcbot added the to-announce Announce this issue on triage meeting label Oct 30, 2022
@Aaron1011
Copy link
Member Author

r? @petrochenkov

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Oct 31, 2022

📌 Commit 7d82cad has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Nov 1, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 1, 2022
@bors
Auto merge of rust-lang#103841 - Dylan-DPC:rollup-rff2x1l, r=Dylan-DPC
ab5a2bc 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#84022 (Make PROC_MACRO_DERIVE_RESOLUTION_FALLBACK a hard error)
 - rust-lang#103760 (resolve: Turn the binding from `#[macro_export]` into a proper `Import`)
 - rust-lang#103813 (rustdoc: remove unnecessary CSS `.search-results { clear: both }`)
 - rust-lang#103817 (rustdoc: rename syntax highlighting CSS class `attribute` to `attr`)
 - rust-lang#103833 (:arrow_up: rust-analyzer)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9f603fe into rust-lang:master Nov 1, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 1, 2022
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jan 5, 2023
@pnkfelix
Copy link
Member

this probably should have been marked as rollup=never

@pnkfelix pnkfelix mentioned this pull request Jan 20, 2023
Open
@pnkfelix
Copy link
Member

In particular, I have confirmed that this PR was what injected issue #106337.

I'm planning to open a PR reverting this one and beta-nominate it for the 1.67-beta (due for release as 1.67-stable on 2023-01-26) in order to buy us some time to talk about strategies for the macro implementation pattern described in #106337 and in issue #64079

@pnkfelix pnkfelix mentioned this pull request Jan 20, 2023
Merged
cuviper added a commit to cuviper/rust that referenced this pull request Jan 21, 2023
@cuviper
Remove relnote for rust-lang#84022 due to revert rust-lang#107133
43c18e9
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2023
@bors
Auto merge of rust-lang#107133 - pnkfelix:revert-pr-84022-for-issue-1…
85da15c 
…06337, r=Mark-Simulacrum

Revert "Make PROC_MACRO_DERIVE_RESOLUTION_FALLBACK a hard error"

This reverts commit 7d82cad aka PR rust-lang#84022

I am doing this to buy us some time with respect to issue rust-lang#106337 w.r.t. the 1.67 release.
@pnkfelix pnkfelix mentioned this pull request Jan 26, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. I-needs-decision Issue: In need of a decision. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.