Skip to content

Fix force-warns to allow dashes. #86117

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jun 7, 2021

The --force-warns flag was not allowing lint names with dashes, only supporting underscores. This changes it to allow dashes to match the behavior of the A/W/D/F flags.

@rust-highfive
Copy link
Contributor

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2021
Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ♥

@bors
Copy link
Collaborator

bors commented Jun 10, 2021

☔ The latest upstream changes (presumably #82639) made this pull request unmergeable. Please resolve the merge conflicts.

@ehuss ehuss force-pushed the force-warns-underscore branch from 14d7754 to 7905473 Compare June 10, 2021 15:38
@m-ou-se
Copy link
Member

m-ou-se commented Jun 14, 2021

Looks good to me! ♥️

@bors r=rylev

@bors
Copy link
Collaborator

bors commented Jun 14, 2021

📌 Commit 7905473 has been approved by rylev

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2021
@bors
Copy link
Collaborator

bors commented Jun 14, 2021

⌛ Testing commit 7905473 with merge 3044419...

@bors
Copy link
Collaborator

bors commented Jun 14, 2021

☀️ Test successful - checks-actions
Approved by: rylev
Pushing 3044419 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 14, 2021
@bors bors merged commit 3044419 into rust-lang:master Jun 14, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 14, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants