Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

windows: Return the "Not Found" error when a path is empty #90942

Merged
merged 1 commit into from
Nov 19, 2021
Merged

windows: Return the "Not Found" error when a path is empty #90942

merged 1 commit into from
Nov 19, 2021

Conversation

JohnTitor
Copy link
Member

Fixes #90940

@rust-highfive
Copy link
Collaborator

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 16, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Nov 17, 2021

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Nov 17, 2021

📌 Commit ddc1d58 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 18, 2021
@matthiaskrgr
Rollup merge of rust-lang#90942 - JohnTitor:should-os-error-3, r=m-ou-se
005be61 
windows: Return the "Not Found" error when a path is empty

Fixes rust-lang#90940
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 18, 2021
Closed
@apiraino apiraino added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Nov 18, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 18, 2021
@matthiaskrgr
Rollup merge of rust-lang#90942 - JohnTitor:should-os-error-3, r=m-ou-se
b9414a8 
windows: Return the "Not Found" error when a path is empty

Fixes rust-lang#90940
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 18, 2021
Closed
@JohnTitor JohnTitor mentioned this pull request Nov 19, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 19, 2021
@bors
Auto merge of rust-lang#91033 - JohnTitor:rollup-sr9zg6o, r=JohnTitor
e8423e6 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#89258 (Make char conversion functions unstably const)
 - rust-lang#90578 (add const generics test)
 - rust-lang#90633 (Refactor single variant `Candidate` enum into a struct)
 - rust-lang#90800 (bootstap: create .cargo/config only if not present)
 - rust-lang#90942 (windows: Return the "Not Found" error when a path is empty)
 - rust-lang#90947 (Move some tests to more reasonable directories - 9.5)
 - rust-lang#90961 (Suggest removal of arguments for unit variant, not replacement)
 - rust-lang#90990 (Arenas cleanup)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f62984f into rust-lang:master Nov 19, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 19, 2021
@JohnTitor JohnTitor deleted the should-os-error-3 branch November 19, 2021 09:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ChrisDenton ChrisDenton ChrisDenton left review comments

Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.

windows: An empty path returns os error 123 instead of os error 3 with recent nightly
7 participants
@JohnTitor @rust-highfive @m-ou-se @bors @ChrisDenton @apiraino @rustbot