Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Move some tests to more reasonable directories - 9.5 #90947

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Move some tests to more reasonable directories - 9.5 #90947

merged 1 commit into from
Nov 19, 2021

Conversation

c410-f3r
Copy link
Contributor

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 16, 2021
@c410-f3r c410-f3r changed the title Move some tests to more reasonable directories Move some tests to more reasonable directories - 10 Nov 16, 2021
@rust-log-analyzer

This comment has been minimized.

# to view
@c410-f3r c410-f3r closed this Nov 16, 2021
@c410-f3r c410-f3r reopened this Nov 16, 2021
@petrochenkov
Copy link
Contributor

@c410-f3r
Could you submit the parser -> lexer move as a separate PR?
It's sufficiently different from the remaining changes, and it's hard to review PRs with hundreds of moved tests anyway.

@c410-f3r
Copy link
Contributor Author

@c410-f3r Could you submit the parser -> lexer move as a separate PR? It's sufficiently different from the remaining changes, and it's hard to review PRs with hundreds of moved tests anyway.

Done

@c410-f3r c410-f3r changed the title Move some tests to more reasonable directories - 10 Move some tests to more reasonable directories - 9.5 Nov 16, 2021
@petrochenkov
Copy link
Contributor

petrochenkov commented Nov 18, 2021 •
edited
Loading

with-no-generics-in-parameter-list.rs -> parser
no-mangle-associated-fn.rs -> extern (or foreign, the subdirectories duplicate each other)
byte-literals.rs -> array-slice-vec
ignore-all-the-things.rs -> pattern
placement-syntax.rs -> parser
tail-direct.rs -> can be removed now
blind-item-mixed-crate-use-item.rs -> resolve
blind-item-mixed-use-item.rs -> resolve
raw-fat-ptr.rs -> stdlib-unit-tests
link-cfg-works.rs -> linkage-attr (for now)
impl-privacy-xc-2.rs -> privacy
reachable-unnameable-items.rs -> privacy
leak-unique-as-tydesc.rs -> can be removed now
pure-sum.rs -> can be removed now
volatile-fat-ptr.rs -> stdlib-unit-tests
unify-return-ty.rs -> typeck
no-std-1.rs -> resolve
no-std-2.rs -> resolve
no-std-3.rs -> resolve
thread-local-not-in-prelude.rs -> hygiene
llvm-pr32379.rs -> codegen maybe
backtrace-debuginfo.rs -> runtime
matches2021.rs -> stdlib-unit-tests
atomic-print.rs -> runtime or threads-sendsync
init-large-type.rs -> codegen
clone-with-exterior.rs -> threads-sendsync
dyn-trait-compatibility.rs -> parser
export-tag-variant.rs -> privacy
export.rs -> can be removed now
pathless-extern-ok.rs -> resolve
float-literal-inference-restrictions.rs -> mismatched_types
kindck-implicit-close-over-mut-var.rs -> borrowck or closures
minmax-stability-issue-23687.rs -> stdlib-unit-tests
retslot-cast.rs -> coercion
syntax-trait-polarity-feature-gate.rs -> can be removed now
ufcs-type-params.rs -> typeck
not-sync.rs -> stdlib-unit-tests
synthetic-param.rs -> impl-trait (or keep in place, it's removed in #91002)

The blind directory doesn't make sense and its content should be moved to resolve.
I'm again convinced that the binding directory doesn't make sense and needs to be dismantled.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2021
@petrochenkov petrochenkov mentioned this pull request Nov 18, 2021
Merged
@c410-f3r c410-f3r force-pushed the testsssssss branch 2 times, most recently from 4ab6daf to bb13b98 Compare November 18, 2021 11:10
@c410-f3r
Copy link
Contributor Author

Should be good now

@petrochenkov
Copy link
Contributor

impl-privacy-xc-2.rs -> privacy

@bors r+

@bors
Copy link
Contributor

bors commented Nov 18, 2021

📌 Commit bb13b98eb650df6072b4b24fb5bf4e91e28631f2 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 18, 2021
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Nov 18, 2021

📌 Commit 41d9abd has been approved by petrochenkov

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 18, 2021
@JohnTitor
Rollup merge of rust-lang#91002 - petrochenkov:nosynth, r=davidtwco
377a20e 
rustc: Remove `#[rustc_synthetic]`

This function parameter attribute was introduced in rust-lang#44866 as an intermediate step in implementing `impl Trait`, it's not necessary or used anywhere by itself.

Noticed while reviewing rust-lang#90947.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 18, 2021
@JohnTitor
Rollup merge of rust-lang#91002 - petrochenkov:nosynth, r=davidtwco
08c1639 
rustc: Remove `#[rustc_synthetic]`

This function parameter attribute was introduced in rust-lang#44866 as an intermediate step in implementing `impl Trait`, it's not necessary or used anywhere by itself.

Noticed while reviewing rust-lang#90947.
@JohnTitor JohnTitor mentioned this pull request Nov 19, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 19, 2021
@bors
Auto merge of rust-lang#91033 - JohnTitor:rollup-sr9zg6o, r=JohnTitor
e8423e6 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#89258 (Make char conversion functions unstably const)
 - rust-lang#90578 (add const generics test)
 - rust-lang#90633 (Refactor single variant `Candidate` enum into a struct)
 - rust-lang#90800 (bootstap: create .cargo/config only if not present)
 - rust-lang#90942 (windows: Return the "Not Found" error when a path is empty)
 - rust-lang#90947 (Move some tests to more reasonable directories - 9.5)
 - rust-lang#90961 (Suggest removal of arguments for unit variant, not replacement)
 - rust-lang#90990 (Arenas cleanup)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 022709f into rust-lang:master Nov 19, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 19, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
6 participants
@c410-f3r @rust-log-analyzer @petrochenkov @bors @rust-highfive @rustbot