Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Avoid suggesting literal formatting that turns into member access #90989

Merged

Conversation

notriddle
Copy link
Contributor

Fixes #90974

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 17, 2021
@rust-log-analyzer

This comment has been minimized.

@notriddle notriddle force-pushed the notriddle/rustc-suggest-float-ending-in-dot branch from dd2da7b to f939488 Compare November 17, 2021 21:04
@rust-log-analyzer

This comment has been minimized.

@notriddle notriddle force-pushed the notriddle/rustc-suggest-float-ending-in-dot branch from f939488 to be46ebb Compare November 17, 2021 23:14
@rust-log-analyzer

This comment has been minimized.

@notriddle notriddle force-pushed the notriddle/rustc-suggest-float-ending-in-dot branch from be46ebb to a7261c3 Compare November 18, 2021 00:23
@sanxiyn
Copy link
Member

sanxiyn commented Nov 18, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 18, 2021

📌 Commit a7261c3 has been approved by sanxiyn

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 18, 2021
…loat-ending-in-dot, r=sanxiyn

Avoid suggesting literal formatting that turns into member access

Fixes rust-lang#90974
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 18, 2021
…loat-ending-in-dot, r=sanxiyn

Avoid suggesting literal formatting that turns into member access

Fixes rust-lang#90974
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 18, 2021
…loat-ending-in-dot, r=sanxiyn

Avoid suggesting literal formatting that turns into member access

Fixes rust-lang#90974
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 18, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 18, 2021
Rollup of 8 pull requests

Successful merges:

 - rust-lang#90386 (Add `-Zassert-incr-state` to assert state of incremental cache)
 - rust-lang#90438 (Clean up mess for --show-coverage documentation)
 - rust-lang#90480 (Mention `Vec::remove` in `Vec::swap_remove`'s docs)
 - rust-lang#90607 (Make slice->str conversion and related functions `const`)
 - rust-lang#90750 (rustdoc: Replace where-bounded Clean impl with simple function)
 - rust-lang#90895 (require full validity when determining the discriminant of a value)
 - rust-lang#90989 (Avoid suggesting literal formatting that turns into member access)
 - rust-lang#91002 (rustc: Remove `#[rustc_synthetic]`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dfbbb3b into rust-lang:master Nov 18, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 18, 2021
@notriddle notriddle deleted the notriddle/rustc-suggest-float-ending-in-dot branch November 18, 2021 23:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect suggestion for method call on ambiguous floating-point literal
8 participants