-
Notifications
You must be signed in to change notification settings - Fork 547
Glossary page is corrupted #1041
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
I think I found the problem. The This change was introduced in pulldown-cmark-to-cmark here Still thinking what we can do about it. |
This doesn't solve the underlying problem, but we could change the layout of the Glossary to be like: #### arena/arena allocation
... info about arenas
#### TyCtxt
... info about TyCtxt which should "solve" the issue. I think the current Glossary layout is hard to read and navigate as it is, this approach would mean:
So, why not? ;) |
I like this approach, if there's consensus I'll report the root cause upstream and "fix" ours this way. |
Could I make a PR to solve this in @ehuss 's approach? |
@VitalyAnkh absolutely! I had started on this but hadn't gotten to fixing all the references in the rest of the book. Go ahead! |
I find it's hard to add link without |
I think |
@LeSeulArtichaut Thanks! |
This has been fixed by #1146. |
Uh oh!
There was an error while loading. Please reload this page.
The glossary page is not rendering correctly. Currently, it looks like this:
It looks like this is caused by mdbook-toc. Looking at the implementation, it looks like it is using pulldown-cmark-to-cmark, which in my experience is not very reliable.
(EDIT: no aspersions meant for pulldown-cmark-to-cmark, it is a very hard problem to convert the events back to markdown.)
The text was updated successfully, but these errors were encountered: