-
Notifications
You must be signed in to change notification settings - Fork 547
Update logging for tracing
#892
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
@oli-obk do you have time to work on this? |
We are not using spans or But yea, some minimal updating of the logging section would be a good thing. I'll try to find some time, but won't complain if someone grabs it |
I'm currently working on the survey translations but in a few days I'll free up and could take this :) Won't claim it in case someone wants to do it right away. |
I fixed this in #997. |
It looks like the compiler moved to the
tracing
crate. I think at a minimum, the section at https://rustc-dev-guide.rust-lang.org/compiler-debugging.html?highlight=log#getting-logging-output should be updated to mention that.I don't actually know why it was changed, what the differences are, or what the motivation was. rust-lang/compiler-team#331 and rust-lang/rust#74726 don't really say. Is there anything I need to know about the differences? Are there any examples of when using spans or
#[instrument]
would be useful? Should messages use structured fields (and how or why is that useful)?The text was updated successfully, but these errors were encountered: